fix: globals.css rule for min-h-\[750px\] classname
#13
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
examples/demo/package.json
Outdated
| "@vercel/analytics": "^1.5.0", | ||
| "clsx": "^2.1.1", | ||
| "framer-motion": "^12.19.2", | ||
| "motion": "^12.16.0", |
There was a problem hiding this comment.
Remove framer-motion. motion, and framer-motion are now the same lib.
replace "motion": "^12.16.0",
with
"motion": "12.18.1",
the ^ carrot in the json file downloads the latest package. the latest update is what is causing the Error: It's currently unsupported to use "export *" in a client boundary. Please use named exports instead. Error.
| @@ -1,3 +1,4 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
remove use client from the layout. (it is important we keep our app SSR)
|
@Thayorns Thank you once again for your PR. it looks Great😎. after looking into it. I understand why you added "use client" to the layout. Motion is no longer working with Next 15 build. as noted in motion issue #3211 until they fix that problem, please follow the instructions provided in the review and the PR will be ready for approval. thanks for your hard work. |
|
@Austin1serb, Thanks for the clarification. The |
2 participants
Summary
"Closes #10"
We have this
div classname='mx-auto flex min-h-[100dvh] items-center justify-center bg-gray-100'wrapper that is flexed & justified center.Then we have inner
div className="min-h-[750px] w-full"with fixedmin-height 750that slightly ruins flexes above.I set
min-heightas "auto" andmargin: 80px auto;so the central content never pushes top and bottom navigation on my local end.I have tested it on a smaller iphone S mode and everything is fine. The scroll appearing is correct because of the main content height.
Type of Change
Checklist
pnpm test)pnpm lint && pnpm format)feat:,fix:, etc.)Notes for Reviewer
If it fixes the problem with top\bottom paddings - let me know!