Require the NativePerformance module and drop the legacy performance fallback (#57566)#57566
Closed
rubennorte wants to merge 1 commit into
Closed
Require the NativePerformance module and drop the legacy performance fallback (#57566)#57566rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112116429. |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 15, 2026
…fallback (react#57566) Summary: Pull Request resolved: react#57566 `setUpPerformance` previously branched between the modern Performance API setup and a barebones `performance` stub depending on whether the native Performance module was available. The native module is now always present in supported runtimes, so this consolidates everything on the modern setup and removes the dead fallback path. - `NativePerformance` is now resolved via `getEnforcing` instead of a nullable `get`, and its `timeOrigin` method is no longer optional (the native module always implements it). - Removed the legacy `performance` stub and the `global.nativePerformanceNow` fallbacks, along with the now-redundant `nullthrows`/null checks and the `getCurrentTimeStamp` indirection (native `now`/`timeOrigin` are cached directly). - `Libraries/Core/setUpPerformance` is kept as a thin alias of the internal setup module so external callers importing it keep working; the internal module was renamed from `setUpPerformanceModern` to `setUpPerformance`. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D112116429
rubennorte
force-pushed
the
export-D112116429
branch
from
July 15, 2026 14:04
f29b012 to
2751ef7
Compare
meta-codesync
Bot
changed the title
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D112116429
branch
from
July 15, 2026 14:32
2751ef7 to
e708303
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 15, 2026
…fallback (react#57566) Summary: Pull Request resolved: react#57566 `setUpPerformance` previously branched between the modern Performance API setup and a barebones `performance` stub depending on whether the native Performance module was available. The native module is now always present in supported runtimes, so this consolidates everything on the modern setup and removes the dead fallback path. - `NativePerformance` is now resolved via `getEnforcing` instead of a nullable `get`, and its `timeOrigin` method is no longer optional (the native module always implements it). - Removed the legacy `performance` stub and the `global.nativePerformanceNow` fallbacks, along with the now-redundant `nullthrows`/null checks and the `getCurrentTimeStamp` indirection (native `now`/`timeOrigin` are cached directly). - `Libraries/Core/setUpPerformance` is kept as a thin alias of the internal setup module so external callers importing it keep working; the internal module was renamed from `setUpPerformanceModern` to `setUpPerformance`. Changelog: [Internal] Reviewed By: hoxyq, cipolleschi Differential Revision: D112116429
rubennorte
force-pushed
the
export-D112116429
branch
from
July 15, 2026 17:25
e708303 to
018d620
Compare
meta-codesync
Bot
changed the title
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 15, 2026
…fallback (react#57566) Summary: Pull Request resolved: react#57566 `setUpPerformance` previously branched between the modern Performance API setup and a barebones `performance` stub depending on whether the native Performance module was available. The native module is now always present in supported runtimes, so this consolidates everything on the modern setup and removes the dead fallback path. - `NativePerformance` is now resolved via `getEnforcing` instead of a nullable `get`, and its `timeOrigin` method is no longer optional (the native module always implements it). - Removed the legacy `performance` stub and the `global.nativePerformanceNow` fallbacks, along with the now-redundant `nullthrows`/null checks and the `getCurrentTimeStamp` indirection (native `now`/`timeOrigin` are cached directly). - `Libraries/Core/setUpPerformance` is kept as a thin alias of the internal setup module so external callers importing it keep working; the internal module was renamed from `setUpPerformanceModern` to `setUpPerformance`. Changelog: [Internal] Reviewed By: hoxyq, cipolleschi Differential Revision: D112116429
rubennorte
force-pushed
the
export-D112116429
branch
from
July 15, 2026 18:15
018d620 to
ba5224c
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2026
…fallback (react#57566) Summary: Pull Request resolved: react#57566 `setUpPerformance` previously branched between the modern Performance API setup and a barebones `performance` stub depending on whether the native Performance module was available. The native module is now always present in supported runtimes, so this consolidates everything on the modern setup and removes the dead fallback path. - `NativePerformance` is now resolved via `getEnforcing` instead of a nullable `get`, and its `timeOrigin` method is no longer optional (the native module always implements it). - Removed the legacy `performance` stub and the `global.nativePerformanceNow` fallbacks, along with the now-redundant `nullthrows`/null checks and the `getCurrentTimeStamp` indirection (native `now`/`timeOrigin` are cached directly). - `Libraries/Core/setUpPerformance` is kept as a thin alias of the internal setup module so external callers importing it keep working; the internal module was renamed from `setUpPerformanceModern` to `setUpPerformance`. Changelog: [Internal] Reviewed By: hoxyq, cipolleschi Differential Revision: D112116429
rubennorte
force-pushed
the
export-D112116429
branch
from
July 16, 2026 11:53
ba5224c to
24962a6
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2026
…fallback (react#57566) Summary: Pull Request resolved: react#57566 `setUpPerformance` previously branched between the modern Performance API setup and a barebones `performance` stub depending on whether the native Performance module was available. The native module is now always present in supported runtimes, so this consolidates everything on the modern setup and removes the dead fallback path. - `NativePerformance` is now resolved via `getEnforcing` instead of a nullable `get`, and its `timeOrigin` method is no longer optional (the native module always implements it). - Removed the legacy `performance` stub and the `global.nativePerformanceNow` fallbacks, along with the now-redundant `nullthrows`/null checks and the `getCurrentTimeStamp` indirection (native `now`/`timeOrigin` are cached directly). - `Libraries/Core/setUpPerformance` is kept as a thin alias of the internal setup module so external callers importing it keep working; the internal module was renamed from `setUpPerformanceModern` to `setUpPerformance`. Changelog: [Internal] Reviewed By: hoxyq, cipolleschi Differential Revision: D112116429
rubennorte
force-pushed
the
export-D112116429
branch
from
July 16, 2026 12:00
24962a6 to
1bb136a
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2026
…fallback (react#57566) Summary: Pull Request resolved: react#57566 `setUpPerformance` previously branched between the modern Performance API setup and a barebones `performance` stub depending on whether the native Performance module was available. The native module is now always present in supported runtimes, so this consolidates everything on the modern setup and removes the dead fallback path. - `NativePerformance` is now resolved via `getEnforcing` instead of a nullable `get`, and its `timeOrigin` method is no longer optional (the native module always implements it). - Removed the legacy `performance` stub and the `global.nativePerformanceNow` fallbacks, along with the now-redundant `nullthrows`/null checks and the `getCurrentTimeStamp` indirection (native `now`/`timeOrigin` are cached directly). - `Libraries/Core/setUpPerformance` is kept as a thin alias of the internal setup module so external callers importing it keep working; the internal module was renamed from `setUpPerformanceModern` to `setUpPerformance`. Changelog: [Internal] Reviewed By: hoxyq, cipolleschi Differential Revision: D112116429
rubennorte
force-pushed
the
export-D112116429
branch
from
July 16, 2026 12:09
1bb136a to
72317ed
Compare
…fallback (react#57566) Summary: Pull Request resolved: react#57566 `setUpPerformance` previously branched between the modern Performance API setup and a barebones `performance` stub depending on whether the native Performance module was available. The native module is now always present in supported runtimes, so this consolidates everything on the modern setup and removes the dead fallback path. - `NativePerformance` is now resolved via `getEnforcing` instead of a nullable `get`, and its `timeOrigin` method is no longer optional (the native module always implements it). - Removed the legacy `performance` stub and the `global.nativePerformanceNow` fallbacks, along with the now-redundant `nullthrows`/null checks and the `getCurrentTimeStamp` indirection (native `now`/`timeOrigin` are cached directly). - `Libraries/Core/setUpPerformance` is kept as a thin alias of the internal setup module so external callers importing it keep working; the internal module was renamed from `setUpPerformanceModern` to `setUpPerformance`. Changelog: [Internal] Reviewed By: hoxyq, cipolleschi Differential Revision: D112116429
rubennorte
force-pushed
the
export-D112116429
branch
from
July 16, 2026 12:13
72317ed to
5f4e381
Compare
|
This pull request has been merged in afc1651. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
setUpPerformancepreviously branched between the modern Performance API setup and a barebonesperformancestub depending on whether the native Performance module was available. The native module is now always present in supported runtimes, so this consolidates everything on the modern setup and removes the dead fallback path.NativePerformanceis now resolved viagetEnforcinginstead of a nullableget, and itstimeOriginmethod is no longer optional (the native module always implements it).performancestub and theglobal.nativePerformanceNowfallbacks, along with the now-redundantnullthrows/null checks and thegetCurrentTimeStampindirection (nativenow/timeOriginare cached directly).Libraries/Core/setUpPerformanceis kept as a thin alias of the internal setup module so external callers importing it keep working; the internal module was renamed fromsetUpPerformanceModerntosetUpPerformance.Changelog: [Internal]
Reviewed By: hoxyq, cipolleschi
Differential Revision: D112116429