Fix adjustsFontSizeToFit clipping when container height shrinks on Android#57597
Open
imsankalp wants to merge 1 commit into
Open
Fix adjustsFontSizeToFit clipping when container height shrinks on Android#57597imsankalp wants to merge 1 commit into
imsankalp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When a
<Text adjustsFontSizeToFit>component's container height decreases dynamically (e.g. height=60 → height=20), the text is clipped instead of having its font size recalculated.Root cause:
mShouldAdjustSpannableFontSize— the gate that triggers font recalculation inonDraw— is only set by text-content setters (setSpanned,setNumberOfLines, etc.). A pure container resize never sets it. Meanwhile the background Fabric measurement thread mutates the shared cached spannable (tagToSpannableCache) to the larger font size. When the container then shrinks,onDrawskips recalculation and draws the stale large font in the smaller container, causing clipping.Fix: Override
onSizeChangedinReactTextViewto setmShouldAdjustSpannableFontSize = truewhenever the view dimensions change andadjustsFontSizeToFitis active. Android automatically schedules a redraw on size change, so the nextonDrawrecalculates the font with the correct current height.Changelog:
[ANDROID] [FIXED] - Fix Text with adjustsFontSizeToFit being clipped when container height decreases dynamically
Test Plan:
Tested using the existing RNTester example which already reproduces this bug:
The reproducer is
packages/rn-tester/js/examples/Text/TextAdjustsDynamicLayoutExample.js.