Skip to content

Migrate Node.js builtin imports to node: scheme (#57611)#57611

Closed
huntie wants to merge 1 commit into
react:mainfrom
huntie:export-D112803684
Closed

Migrate Node.js builtin imports to node: scheme (#57611)#57611
huntie wants to merge 1 commit into
react:mainfrom
huntie:export-D112803684

Conversation

@huntie

@huntie huntie commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary:

Directly follows D112733139 (Metro).

Motivation

  • New Node builtins are only available under the prefix (e.g. node:sqlite), as this allows Node to introduce them without ecosystem-breaking changes, so this is the direction of travel and the only choice that'll allow consistency.
  • Encouraging them and grouping them separately makes it easier to reason about a module's 3rd party dependencies.

Changelog: [Internal]

Reviewed By: robhogan

Differential Revision: D112803684

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 20, 2026
@meta-codesync

meta-codesync Bot commented Jul 20, 2026

Copy link
Copy Markdown

@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112803684.

@huntie huntie changed the title Use node: scheme to import Node.js builtins Migrate Node.js builtin imports to node: scheme Jul 20, 2026
Summary:
Pull Request resolved: react#57611

Directly follows D112733139 (Metro).

**Motivation**

- New Node builtins are *only* available under the prefix (e.g. `node:sqlite`), as this allows Node to introduce them without ecosystem-breaking changes, so this is the direction of travel and the only choice that'll allow consistency.
- Encouraging them and grouping them separately makes it easier to reason about a module's 3rd party dependencies.

Changelog: [Internal]

Reviewed By: robhogan

Differential Revision: D112803684
@huntie
huntie force-pushed the export-D112803684 branch from 0aad93f to f9138b1 Compare July 20, 2026 13:21
@meta-codesync meta-codesync Bot changed the title Migrate Node.js builtin imports to node: scheme Migrate Node.js builtin imports to node: scheme (#57611) Jul 20, 2026
@meta-codesync meta-codesync Bot closed this in 89300ac Jul 21, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Jul 21, 2026
@meta-codesync

meta-codesync Bot commented Jul 21, 2026

Copy link
Copy Markdown

This pull request has been merged in 89300ac.

@huntie
huntie deleted the export-D112803684 branch July 21, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant