Drop stale $FlowFixMe suppressions for node: imports (#57612)#57612
Closed
huntie wants to merge 2 commits into
Closed
Drop stale $FlowFixMe suppressions for node: imports (#57612)#57612huntie wants to merge 2 commits into
huntie wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112803683. |
Summary: A stylistic choice to unify on `node:`-prefixed imports, e.g. `fs` -> `node:fs`. **Motivation** Follows D112733139 (Metro): - New Node builtins are *only* available under the prefix (e.g. `node:sqlite`), as this allows Node to introduce them without ecosystem-breaking changes, so this is the direction of travel and the only choice that'll allow consistency. - Encouraging them and grouping them separately makes it easier to reason about a module's 3rd party dependencies. Changelog: [Internal] Differential Revision: D112803684
huntie
force-pushed
the
export-D112803683
branch
from
July 20, 2026 13:18
931c9bd to
3a77453
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 20, 2026
Summary: Pull Request resolved: react#57612 Cleanup — these types are already declared in `react-native-github/flow-typed/environment/node.js` and resolve under Flow. The `$FlowFixMe[cannot-resolve-module]` suppressions on these imports are therefore stale. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D112803683
meta-codesync
Bot
changed the title
Summary: Pull Request resolved: react#57612 Cleanup — these types are already declared in `react-native-github/flow-typed/environment/node.js` and resolve under Flow. The `$FlowFixMe[cannot-resolve-module]` suppressions on these imports are therefore stale. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D112803683
huntie
force-pushed
the
export-D112803683
branch
from
July 20, 2026 13:23
3a77453 to
9ebf7c1
Compare
|
This pull request has been merged in 527698f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Cleanup — these types are already declared in
react-native-github/flow-typed/environment/node.jsand resolve under Flow. The$FlowFixMe[cannot-resolve-module]suppressions on these imports are therefore stale.Changelog: [Internal]
Reviewed By: robhogan
Differential Revision: D112803683