Repository navigation
Add LegacyFunction to preserve callback compatibility - #59096
Closed
SamChou19815 wants to merge 1 commit into
Closed
SamChou19815 wants to merge 1 commit into
SamChou19815 wants to merge 1 commit into
Conversation
Summary: With `experimental.function_and_object_type_is_no_longer_any`, Flow resolves `Function` to the builtin class type instead of `any`. Add `LegacyFunction` as a global compat type, following `LegacyObject`, and use it for the legacy callbacks in `Alert`, `Animated`, `PushNotificationIOS`, and `Dimensions`. The TypeScript API pre-transform replaces `LegacyFunction` with `Function`, preserving the generated public API. Remove the `unclear-type` suppressions made unnecessary by the compat type. Changelog: [Internal] Differential Revision: D125351850
meta-cla
Bot
added
the
CLA Signed
|
@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125351850. |
|
This pull request has been merged in cb5ea03. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
With
experimental.function_and_object_type_is_no_longer_any, Flow resolvesFunctionto the builtin class type instead ofany. AddLegacyFunctionas a global compat type, followingLegacyObject, and use it for the legacy callbacks inAlert,Animated,PushNotificationIOS, andDimensions.The TypeScript API pre-transform replaces
LegacyFunctionwithFunction, preserving the generated public API. Remove theunclear-typesuppressions made unnecessary by the compat type.Changelog: [Internal]
Differential Revision: D125351850