Remove DisposableExtensions and update System.Reactive #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted the custom DisposableExtensions class and updated the System.Reactive package to version 6.1.0. Updated tests to use System.Reactive.Disposables.Fluent, reflecting the migration to built-in extension methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
update
What is the current behavior?
provides Disposable Extensions - DisposeWith
What is the new behavior?
Deleted the custom DisposableExtensions class and updated the System.Reactive package to version 6.1.0.
Updated tests to use System.Reactive.Disposables.Fluent, reflecting the migration to built-in extension methods.
What might this PR break?
DisposeWith is now under namespace System.Reactive.Disposables.Fluent
Please check if the PR fulfills these requirements
Other information: