-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support React19 & drop React 16,17 support #915
base: master
Are you sure you want to change the base?
Conversation
someone please pay attention to this PR |
@@ -197,35 +196,6 @@ describe('Transition', () => { | |||
}); | |||
}); | |||
|
|||
it('should use `React.findDOMNode` when `nodeRef` is not provided', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to skip it conditionally based on React version
@jquense I'd say we should update our build settings , outdated dependencies and documentation system before updating React version. |
you wanna do it? |
Yeah, I'll do it when I have time, but it would be helpful someone takes that. The documentation also depends on PropTypes, which was removed in v19, so it would be better to update the documentation as well. https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-react-apis |
it would be so helpful if this MR would be included soon🙏 |
@sergioviniciuss |
@koba04 I'm seeing an issue when using the Transition component on React v19:
|
This only updates CI settings and tests.
react-transition-group
seems to work with React 19 without any updates