Skip to content

chore(deps): bump @readme/httpsnippet from 6.2.1 to 11.0.0 #1091 #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(deps): bump @readme/httpsnippet from 6.2.1 to 11.0.0 #1091 #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f957932
chore(deps): bump @readme/httpsnippet from 6.2.1 to 11.0.0
dependabot[bot] Oct 1, 2024
612808d
fix(node): fix imports for tests
AndriiAndreiev Feb 10, 2025
c66548e
fix(node): fix module resolution
AndriiAndreiev Feb 10, 2025
fb0fa6b
Merge branch 'main' into dependabot/npm_and_yarn/readme/httpsnippet-1…
AndriiAndreiev Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 16 additions & 63 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/sdk-snippets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"test": "vitest run --coverage"
},
"dependencies": {
"@readme/httpsnippet": "^6.2.1"
"@readme/httpsnippet": "^11.0.0"
},
"devDependencies": {
"@readme/eslint-config": "^14.0.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk-snippets/src/helpers/code-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { CodeBuilderOptions } from '@readme/httpsnippet/dist/helpers/code-builder';
import type { CodeBuilderOptions } from '@readme/httpsnippet/helpers/code-builder';

import { CodeBuilder as HTTPSnippetCodeBuilder } from '@readme/httpsnippet/dist/helpers/code-builder';
import { CodeBuilder as HTTPSnippetCodeBuilder } from '@readme/httpsnippet/helpers/code-builder';

export type { CodeBuilderOptions };

Expand Down
1 change: 1 addition & 0 deletions packages/sdk-snippets/tsconfig.build.json
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domharrington @erunion any idea why we have two separate tsconfig files in this subpackage? any reason why we can't merge them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package is so old, i have no idea.

Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"compilerOptions": {
"moduleResolution": "nodenext",
Copy link
Member

@kanadgupta kanadgupta Feb 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript will be changing the behavior of NodeNext in 5.8 so i'd recommend pinning it like so:

Suggested change
"moduleResolution": "nodenext",
"moduleResolution": "Node16",

"allowJs": true,
"declaration": true,
"downlevelIteration": true,
Expand Down
2 changes: 2 additions & 0 deletions packages/sdk-snippets/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"extends": "./tsconfig.build.json",
"compilerOptions": {
"module": "nodenext",
"moduleResolution": "nodenext",
Comment on lines +4 to +5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove these lines? i believe this can be inferred from the tsconfig.build.json

Suggested change
"module": "nodenext",
"moduleResolution": "nodenext",

"rootDir": ".",

// Allows us to not have to typeguard in catches.
Expand Down