Fix serialization testing#2896
Merged
Merged
Conversation
Contributor
|
Just a note this won't work for testing everything anyway, some things like Any in data classes parsed by Json must be changed to JsonElement so the tests will fail for things like that anyway. There is not really any way around it for that as far as I know either. Other than that this looks fine to me though. |
Collaborator
Author
|
I tested with the MyDramaList If we find a class which is impossible to test we can always add an annotation to bypass the serialization tests. |
Contributor
|
Wow nice that really surprises me... |
Collaborator
Author
|
I was also surprised, Android development is rarely convenient like that 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only other option I could find was moving this to the library JVM tests and keeping ClassGraph, but we lose out on app data class testing in that case.
@Luna712