Skip to content

[DowngradePhp80] Add DowngradeSubstrFalsyRector #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 29 commits into from
Oct 20, 2025
Merged

[DowngradePhp80] Add DowngradeSubstrFalsyRector #339

samsonasik merged 29 commits into from
Oct 20, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Oct 13, 2025

@samsonasik samsonasik mentioned this pull request Oct 13, 2025
Closed
@samsonasik
Copy link
Member Author

samsonasik commented Oct 13, 2025

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik samsonasik marked this pull request as draft October 13, 2025 14:50
@samsonasik
Copy link
Member Author

samsonasik commented Oct 13, 2025

Tested in existing vendor under this repo, it seems there are too many cast that should not be needed. Drafting for now.

@samsonasik samsonasik mentioned this pull request Oct 17, 2025
Merged
samsonasik and others added 24 commits October 20, 2025 16:54
@samsonasik
[DowngradePhp80] Add DowngradeSubstrFalsyRector
13c02b8
@samsonasik
[DowngradePhp80] Add DowngradeSubstrFalsyRector
6d51910
@samsonasik
[DowngradePhp80] Add DowngradeSubstrFalsyRector
12d80c8
@samsonasik
[DowngradePhp80] Add DowngradeSubstrFalsyRector
edb3a4f
@samsonasik
skip negated
d963510
@samsonasik
skip casted bool
e5b2a2e
@samsonasik
skip compared to false
121104e
@actions-user @samsonasik
[ci-review] Rector Rectify
1535735
@samsonasik
skip compared to false
d653bba
@samsonasik
skip zero offset
e0d8b56
@samsonasik
skip zero offset
4b37a51
@samsonasik
skip negative offset
c5feda8
@samsonasik
skip with concat
f1e8eea
@actions-user @samsonasik
[ci-review] Rector Rectify
0569d22
@samsonasik
skip allow falsy arg
a3efa29
@samsonasik
use MethodCall and StaticCall as current ReflectionResolver can get
12077fb
@samsonasik
skip append
6abd075
@samsonasik
skip direct on if cond
b76a519
@samsonasik
skip direct on if cond
0c65912
@samsonasik
skip direct on while and do cond
1ca7c16
@samsonasik
add fixture for skip sprintf arg
47562f0
@samsonasik
skip as array key
4089265
@samsonasik
skip as array dim fetch dim
7e86548
@samsonasik
skip in binary op
0acd09f
@samsonasik samsonasik marked this pull request as ready for review October 20, 2025 10:07
@samsonasik
Copy link
Member Author

samsonasik commented Oct 20, 2025

@TomasVotruba I already applied as many use case skip as possible so it make less noise on downgrade, let's merge to have faster feedback to test :)

@samsonasik samsonasik merged commit 2c4aa18 into main Oct 20, 2025
7 checks passed
@samsonasik samsonasik deleted the falsy branch October 20, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DowngradePhp80] Add DowngradeSubstrFalsyRector

3 participants

@samsonasik @actions-user