Skip to content

YieldDataProviderRector: added failling test #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
staabm wants to merge 3 commits into from
Closed

YieldDataProviderRector: added failling test #414

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b488d76
YieldDataProviderRector: added failling test
staabm Dec 9, 2024
f9e9f91
Update use_data_provider_with_phpdoc.php.inc
staabm Dec 9, 2024
85c620d
Update rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/…
staabm Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions ...ality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
<?php

namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\YieldDataProviderRector\Fixture;

use PHPUnit\Framework\TestCase;

final class UseDataProviderTestPhpdoc extends TestCase
{
#[\PHPUnit\Framework\Attributes\DataProvider('dataProvider')]
#[\PHPUnit\Framework\Attributes\DataProvider('provideDataForProvider')]
public function test(string $filePath): void
{
}

/** @return array<int, array<string>> */
public static function provideDataForProvider()
{
return [
['<?php implode("", $foo, );', '<?php implode($foo, "", );']
];
}

public static function dataProvider()
Copy link
Contributor Author

@staabm staabm Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this provider we could add another case with list<...>

{
return [
['<?php implode(\'\', $foo, );', '<?php implode($foo, );'],
['<?php implode(\'\', $foo, );', '<?php implode($foo, );']
];
}
}

?>
-----
<?php

namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\YieldDataProviderRector\Fixture;

use PHPUnit\Framework\TestCase;

final class UseDataProviderTestPhpdoc extends TestCase
{
#[\PHPUnit\Framework\Attributes\DataProvider('dataProvider')]
#[\PHPUnit\Framework\Attributes\DataProvider('provideDataForProvider')]
public function test(string $filePath): void
{
}

/** @return Iterator<int, array<string>> */
public static function provideDataForProvider(): \Iterator
{
yield ['<?php implode("", $foo, );', '<?php implode($foo, "", );'];
}

public static function dataProvider(): \Iterator
{
yield ['<?php implode(\'\', $foo, );', '<?php implode($foo, );'];
yield ['<?php implode(\'\', $foo, );', '<?php implode($foo, );'];
}
}

?>
Loading