Skip to content

[PHPUnit] Support list in YieldDataProviderRector #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Dec 10, 2024
Merged

[PHPUnit] Support list in YieldDataProviderRector #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83686fc
[PHPUnit] Support list in YieldDataProviderRector
staabm Dec 10, 2024
f5a5b7b
cs
staabm Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ final class UseDataProviderTestPhpdoc extends TestCase
];
}

/** @return list<array<string>> */
public static function dataProvider()
{
return [
Expand Down Expand Up @@ -51,6 +52,7 @@ final class UseDataProviderTestPhpdoc extends TestCase
yield ['<?php implode("", $foo, );', '<?php implode($foo, "", );'];
}

/** @return \Iterator<int<0, max>, array<string>> */
public static function dataProvider(): \Iterator
{
yield ['<?php implode(\'\', $foo, );', '<?php implode($foo, );'];
Expand Down
3 changes: 1 addition & 2 deletions rules/CodeQuality/Rector/Class_/YieldDataProviderRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Return_;
use PHPStan\PhpDocParser\Ast\PhpDoc\ReturnTagValueNode;
use PHPStan\Type\ArrayType;
use PHPStan\Type\Generic\GenericObjectType;
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger;
Expand Down Expand Up @@ -177,7 +176,7 @@ private function removeReturnTag(ClassMethod $classMethod): void
return;
}

if ($phpDocInfo->getReturnType() instanceof ArrayType) {
if ($phpDocInfo->getReturnType()->isArray()->yes()) {
$keyType = $phpDocInfo->getReturnType()
->getIterableKeyType();
$itemType = $phpDocInfo->getReturnType()
Expand Down
Loading