Skip to content

Fixture to test proper refactoring of PHPUnit assertion assertTrue -> assertGreaterThan. #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
biozshock wants to merge 1 commit into from
Closed

Fixture to test proper refactoring of PHPUnit assertion assertTrue -> assertGreaterThan. #531

biozshock wants to merge 1 commit into from

Conversation

@biozshock
Copy link
Contributor

@biozshock biozshock commented Sep 2, 2025

No description provided.

@biozshock
Create assert_true_to_greater_than.php.inc
69246d2 
Fixture to test proper refactoring of PHPUnit assertion.
@samsonasik
Copy link
Member

samsonasik commented Sep 2, 2025

Confirmed:

    public function test()
    {
        self::assertTrue(0 < 1);
        self::assertGreaterThan(0, 1);
    }

is OK.

samsonasik added a commit that referenced this pull request Sep 2, 2025
@samsonasik
Closes #531
ee4b994
@samsonasik samsonasik mentioned this pull request Sep 2, 2025
Merged
@samsonasik
Copy link
Member

samsonasik commented Sep 2, 2025

I cherry-picked your commit at PR:

staabm pushed a commit to staabm/rector-phpunit that referenced this pull request Oct 9, 2025
@samsonasik @biozshock
[CodeQuality] Fix assertGreater/Less apply on AssertComparisonToSpeci…
1947a57 
…ficMethodRector (rectorphp#532)

* Create assert_true_to_greater_than.php.inc

Fixture to test proper refactoring of PHPUnit assertion.

* Closes rectorphp#531

* more

* more fixtures

* should keep order

---------

Co-authored-by: Artem Lopata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@biozshock @samsonasik