Skip to content

[CodeQuality] Handle crash on no @depends on AddParamTypeFromDependsRector #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Sep 5, 2025
Merged

[CodeQuality] Handle crash on no @depends on AddParamTypeFromDependsRector #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0119a35
[CodeQuality] Handle crash on no @depends on AddParamTypeFromDependsR…
samsonasik Sep 5, 2025
8ac44bc
Fix
samsonasik Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...s/CodeQuality/Rector/Class_/AddParamTypeFromDependsRector/Fixture/skip_no_depends.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php

namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\AddParamTypeFromDependsRector\Fixture;

use PHPUnit\Framework\TestCase;

final class SkipNoDepends extends TestCase
{
public function test(): \stdClass
{
return new \stdClass();
}

public function testNoDepends($value)
{
}
}
4 changes: 4 additions & 0 deletions rules/CodeQuality/Rector/Class_/AddParamTypeFromDependsRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,10 @@ private function resolveReturnTypeOfDependsMethod(ClassMethod $classMethod, Clas
{
$dependsMethodName = $this->resolveDependsAnnotationOrAttributeMethod($classMethod);

if ($dependsMethodName === null || $dependsMethodName === '') {
return null;
}

$dependsClassMethod = $class->getMethod($dependsMethodName);

if (! $dependsClassMethod instanceof ClassMethod) {
Expand Down