Skip to content

add float support to scalar argument rule #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Sep 5, 2025
Merged

add float support to scalar argument rule #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions ...all/ScalarArgumentToExpectedParamTypeRector/Fixture/pass_float_to_nullable_string.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?php

namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Fixture;

use PHPUnit\Framework\TestCase;
use Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Source\NullableSetter;

final class PassFloatToNullableString extends TestCase
{
public function test()
{
$nullableSetter = new NullableSetter();
$nullableSetter->setMaybe(123.456);
}
}

?>
-----
<?php

namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Fixture;

use PHPUnit\Framework\TestCase;
use Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Source\NullableSetter;

final class PassFloatToNullableString extends TestCase
{
public function test()
{
$nullableSetter = new NullableSetter();
$nullableSetter->setMaybe('123.456');
}
}

?>
18 changes: 15 additions & 3 deletions rules/CodeQuality/Rector/MethodCall/ScalarArgumentToExpectedParamTypeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Scalar;
use PhpParser\Node\Scalar\Float_;
use PhpParser\Node\Scalar\Int_;
use PhpParser\Node\Scalar\String_;
use PHPStan\Type\IntegerType;
Expand Down Expand Up @@ -114,9 +115,16 @@ public function refactor(Node $node): ?Node
// remove null
$knownParameterType = TypeCombinator::removeNull($knownParameterType);

if ($knownParameterType instanceof StringType && $arg->value instanceof Int_) {
$arg->value = new String_((string) $arg->value->value);
$hasChanged = true;
if ($knownParameterType instanceof StringType) {
if ($arg->value instanceof Int_) {
$arg->value = new String_((string) $arg->value->value);
$hasChanged = true;
}

if ($arg->value instanceof Float_) {
$arg->value = new String_((string) $arg->value->value);
$hasChanged = true;
}
}

if ($knownParameterType instanceof IntegerType && $arg->value instanceof String_) {
Expand Down Expand Up @@ -159,6 +167,10 @@ private function hasStringOrNumberArguments(StaticCall|MethodCall $call): bool
if ($arg->value instanceof String_) {
return true;
}

if ($arg->value instanceof Float_) {
return true;
}
}

return false;
Expand Down