Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions src/Composer/ProjectPackageVersionResolver.php

This file was deleted.

5 changes: 5 additions & 0 deletions src/Enum/PHPUnitClassName.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,9 @@ final class PHPUnitClassName
* @var string
*/
public const ASSERT = 'PHPUnit\Framework\Assert';

/**
* @var string
*/
public const INVOCATION_ORDER = 'PHPUnit\Framework\MockObject\Rule\InvocationOrder';
}
34 changes: 27 additions & 7 deletions src/NodeFactory/MatcherInvocationCountMethodCallNodeFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,28 @@
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Identifier;
use Rector\PHPUnit\Composer\ProjectPackageVersionResolver;
use PHPStan\Reflection\ReflectionProvider;
use Rector\PHPUnit\Enum\ConsecutiveVariable;
use Rector\PHPUnit\Enum\PHPUnitClassName;

/**
* Handle silent rename "getInvocationCount()" to "numberOfInvocations()" in PHPUnit 10
* https://github.com/sebastianbergmann/phpunit/commit/2ba8b7fded44a1a75cf5712a3b7310a8de0b6bb8#diff-3b464bb32b9187dd2d047fd1c21773aa32c19b20adebc083e1a49267c524a980
*/
final readonly class MatcherInvocationCountMethodCallNodeFactory
{
/**
* @var string
*/
private const GET_INVOCATION_COUNT = 'getInvocationCount';

/**
* @var string
*/
private const NUMBER_OF_INVOCATIONS = 'numberOfInvocations';

public function __construct(
private ProjectPackageVersionResolver $projectPackageVersionResolver
private ReflectionProvider $reflectionProvider,
) {
}

Expand All @@ -28,14 +43,19 @@ public function create(): MethodCall

private function getInvocationMethodName(): string
{
$projectPHPUnitVersion = $this->projectPackageVersionResolver->findPackageVersion('phpunit/phpunit');
if (! $this->reflectionProvider->hasClass(PHPUnitClassName::INVOCATION_ORDER)) {
// fallback to PHPUnit 9
return self::GET_INVOCATION_COUNT;
}

$invocationOrderClassReflection = $this->reflectionProvider->getClass(PHPUnitClassName::INVOCATION_ORDER);

if ($projectPHPUnitVersion === null || version_compare($projectPHPUnitVersion, '10.0', '>=')) {
// phpunit 10 naming
return 'numberOfInvocations';
// phpunit 10 naming
if ($invocationOrderClassReflection->hasNativeMethod(self::GET_INVOCATION_COUNT)) {
return self::GET_INVOCATION_COUNT;
}

// phpunit 9 naming
return 'getInvocationCount';
return self::NUMBER_OF_INVOCATIONS;
}
}