Skip to content

[CodeQuality] Ensure verify ClassReflection->hasConstructor() on MethodParametersAndReturnTypesResolver #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 1 commit into from
Sep 21, 2025
Merged

[CodeQuality] Ensure verify ClassReflection->hasConstructor() on MethodParametersAndReturnTypesResolver #550

samsonasik merged 1 commit into from
Sep 21, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Sep 21, 2025

I tried in our project, without it, this cause crash:

         Stack trace:                                                                                                   
         #0                                                                                                             
         /Users/samsonasik/www/rector-src/vendor/rector/rector-phpunit/rules/CodeQuality/Reflection/MethodParametersAndR
         eturnTypesResolver.php(84): PHPStan\Reflection\ClassReflection->getConstructor()

@samsonasik samsonasik force-pushed the ensure-constructor-has branch from 654e7b3 to 36e67df Compare September 21, 2025 13:32
@samsonasik
Copy link
Member Author

samsonasik commented Sep 21, 2025

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Member Author

samsonasik commented Sep 21, 2025

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit c7cfa82 into main Sep 21, 2025
6 checks passed
@samsonasik samsonasik deleted the ensure-constructor-has branch September 21, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik