Turn yield from into multiple yield in PHPUnit Dataprovider
#554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Oct 18, 2025
| ); | ||
|
|
||
| $parameterTypes = []; | ||
| foreach ($extendedParametersAcceptor->getParameters() as $parameterReflection) { |
Contributor
Author
There was a problem hiding this comment.
unrelated fix to get a green build. no functional changes
Member
|
Neat work 👏 Thank you Could you add this role to the code quality set here? It's great fit |
| $statement = $statement->expr; | ||
| } | ||
|
|
||
| if ($statement instanceof Return_ || $statement instanceof YieldFrom) { |
Member
|
I see. The rule is already in the set. Good to go then 👍 |
Member
|
I've triggered the build of |
Contributor
Author
|
thanks! found a interessting case which doesn't work atm |
Member
|
|
Member
|
I created PR to skip mix yield and yield from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes rectorphp/rector#9443