Skip to content

[CodeQuality] Skip in static method on AssertFuncCallToPHPUnitAssertRector #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Nov 11, 2025
Merged

[CodeQuality] Skip in static method on AssertFuncCallToPHPUnitAssertRector #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
956294f
[CodeQuality] Skip in static method on AssertFuncCallToPHPUnitAssertR…
samsonasik Nov 11, 2025
28fde1a
Fix
samsonasik Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ...Rector/FuncCall/AssertFuncCallToPHPUnitAssertRector/Fixture/skip_in_static_method.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?php

namespace Rector\PHPUnit\Tests\CodeQuality\Rector\FuncCall\AssertFuncCallToPHPUnitAssertRector\Fixture;

use PHPUnit\Framework\TestCase;

final class SkipInStaticMethodTest extends TestCase
{
private static function getExceptionMessage(string $fqcn): string
{
$exception = new $fqcn();
assert($exception instanceof \Exception);
Copy link
Member

@TomasVotruba TomasVotruba Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be handled too. The static call on Assert::.. should be used instead.

Copy link
Member Author

@samsonasik samsonasik Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the method is not a test method without test prefix, I think assert is not needed. I guess static method is not a test method tho

Copy link
Member

@TomasVotruba TomasVotruba Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 👍


return $exception->getMessage();
}
}

?>
13 changes: 11 additions & 2 deletions rules/CodeQuality/Rector/FuncCall/AssertFuncCallToPHPUnitAssertRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Name\FullyQualified;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\NodeVisitor;
use PHPStan\Reflection\ClassReflection;
use Rector\PhpParser\Node\Value\ValueResolver;
Expand Down Expand Up @@ -78,15 +79,23 @@ public function test()
*/
public function getNodeTypes(): array
{
return [Closure::class, FuncCall::class];
return [ClassMethod::class, Closure::class, FuncCall::class];
}

/**
* @param Closure|FuncCall $node
* @param ClassMethod|Closure|FuncCall $node
* @return StaticCall|MethodCall|null|NodeVisitor::DONT_TRAVERSE_CHILDREN
*/
public function refactor(Node $node): StaticCall|MethodCall|null|int
{
if ($node instanceof ClassMethod) {
if ($node->isStatic()) {
return NodeVisitor::DONT_TRAVERSE_CHILDREN;
}

return null;
}

if ($node instanceof Closure) {
if ($node->static) {
return NodeVisitor::DONT_TRAVERSE_CHILDREN;
Expand Down