[DeadCode] Skip ClassLikeNameClassNameImportSkipVoter for RecastingRemovalRector

[samsonasik]

Reverts #7446 (review)

@TomasVotruba There is no need php version check, as when rector run on php 7.x, it will be result string|false on substr. Just need to skip RecastingRemovalRector on ClassLikeNameClassNameImportSkipVoter for now.

[TomasVotruba]

Wait with fast merges for this substr issue, I need to review them first :)

[samsonasik]

This is the original issue arise, without skip on rector.php, when run:

bin/rector

the RecastingRemovalRector will remove (string) cast on rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php

-        $subClassName = (string) substr(
+        $subClassName = substr(
            $fullyQualifiedObjectType->getClassName(),
            0,
            -strlen($fullyQualifiedObjectType->getShortName()) - 1
        );

as we are using php 8.2 when running rectify.

rector-src/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php

Lines 53 to 57 in d57b45e

	$subClassName = (string) substr(
	$fullyQualifiedObjectType->getClassName(),
	0,
	-strlen($fullyQualifiedObjectType->getShortName()) - 1
	);

[TomasVotruba]

Yes, that's expected. We need to figure out, why it's returning false in the first place. That's the real bug we're having :)