Skip to content

Conversation

@Tamas-hi
Copy link

Adds an "all" parameter to the withPreparedSets() function to offer the possibility for including all SetList.

Closes rectorphp/rector#9417

Merge all with existings sets

Co-authored-by: Abdul Malik Ikhsan <[email protected]>
@TomasVotruba
Copy link
Member

TomasVotruba commented Oct 17, 2025

I'm having second thoughts about this. Once a few couple months, we add a new set. Just last month we added docblock types, its first version: https://getrector.com/blog/rector-22-new-rules-for-array-docblocks

If this set is enabled magically without anybody knowing, it would cause lot of unwanted changes. The "all" option would turn into "list all but that new set".

It could be similar to "run all available coding standard sets on this code". Some of them might be conflicting, in a loop or mutually exclusive.
That's why I won't merge this, to be opt-in only and explicit. It also clearly shows, what sets are used in the project, just by checking the rector.php file.

Thanks for the work though 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable all prepared sets with a key :all?

3 participants