Skip to content

[CodingStyle] Skip any CallLike with args !== [] on BinaryOpStandaloneAssignsToDirectRector #7469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 5 commits into from
Oct 11, 2025
Merged

[CodingStyle] Skip any CallLike with args !== [] on BinaryOpStandaloneAssignsToDirectRector #7469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e6463b
[CodingStyle] Skip any CallLike with args !== [] on BinaryOpStandalon…
samsonasik Oct 11, 2025
203b934
fix
samsonasik Oct 11, 2025
a081ee4
fix
samsonasik Oct 11, 2025
a95b512
[ci-review] Rector Rectify
actions-user Oct 11, 2025
dc6f6a2
fix
samsonasik Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...thod/BinaryOpStandaloneAssignsToDirectRector/Fixture/skip_any_call_like_with_args.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php

namespace Rector\Tests\CodingStyle\Rector\ClassMethod\BinaryOpStandaloneAssignsToDirectRector\Fixture;

use CodingStyle\Rector\ClassMethod\BinaryOpStandaloneAssignsToDirectRector\Source\SomeGetter;

final class SkipAnyCallLikeWithArgs
{
public function run(SomeGetter $firstSomeGetter, SomeGetter $secondSomeGetter)
{
$first = $firstSomeGetter::getSome($arg, $arg2, $arg3, $arg4, $arg5, $arg6);
$second = $secondSomeGetter::getSome($arg, $arg2, $arg3, $arg4, $arg5, $arg6);

return $first <=> $second;
}
}
4 changes: 2 additions & 2 deletions rules/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
use PhpParser\Node;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\BinaryOp;
use PhpParser\Node\Expr\CallLike;
use PhpParser\Node\Expr\Closure;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\ClassMethod;
Expand Down Expand Up @@ -133,7 +133,7 @@ private function matchToVariableAssignExpr(Stmt $stmt): ?VariableAndExprAssign
}

// skip complex cases
if ($assign->expr instanceof MethodCall && $assign->expr->args !== []) {
if ($assign->expr instanceof CallLike && ! $assign->expr->isFirstClassCallable() && $assign->expr->getArgs() !== []) {
return null;
}

Expand Down