Skip to content

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Oct 20, 2025

 public function demo($someVariable): bool
    {
-        if ($someVariable !== 'a' && $someVariable !== 'b' && $someVariable !== 'c') {
+        if (! in_array($someVariable, ['a', 'b', 'c']), true) {
            return true;
        }

        return false;
    }

@samsonasik
Copy link
Member

rector-phpunit phpstan seems error, I will check.

@samsonasik
Copy link
Member

PHPStan for rector-phpunit fixed at PR:

@samsonasik
Copy link
Member

I will update e2e test in separate PR, the output diff seems now different:

[ERROR] The file
         "./invalid-paths/does-not-exi
         st/" does not exist.

@samsonasik
Copy link
Member

@TomasVotruba I created PR to fix e2e test for invalid paths on latest linux build

@samsonasik
Copy link
Member

@TomasVotruba please rebase 👍 e2e notice is fixed at PR:

due to new webmozart/assert 1.12 :)

@TomasVotruba TomasVotruba merged commit 7f05799 into main Oct 20, 2025
52 checks passed
@TomasVotruba TomasVotruba deleted the tv-not-identical-and branch October 20, 2025 14:51
@TomasVotruba
Copy link
Member Author

Let's ship 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants