-
-
Notifications
You must be signed in to change notification settings - Fork 428
[code-quality] Add RepeatedAndNotEqualToNotInArrayRector #7517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
081545a to
72cf61a
Compare
samsonasik
reviewed
Oct 20, 2025
rules/CodeQuality/Rector/BooleanAnd/RepeatedAndNotEqualToNotInArrayRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Oct 20, 2025
rules/CodeQuality/Rector/BooleanAnd/RepeatedAndNotEqualToNotInArrayRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Oct 20, 2025
rules/CodeQuality/Rector/BooleanAnd/RepeatedAndNotEqualToNotInArrayRector.php
Outdated
Show resolved
Hide resolved
Member
|
rector-phpunit phpstan seems error, I will check. |
Member
|
PHPStan for rector-phpunit fixed at PR: |
Member
|
I will update e2e test in separate PR, the output diff seems now different: |
Member
|
@TomasVotruba I created PR to fix e2e test for invalid paths on latest linux build |
Member
|
@TomasVotruba please rebase 👍 e2e notice is fixed at PR: due to new webmozart/assert 1.12 :) |
samsonasik
reviewed
Oct 20, 2025
…ArrayRector.php Co-authored-by: Abdul Malik Ikhsan <[email protected]>
af482f6 to
4311325
Compare
Member
Author
|
Let's ship 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public function demo($someVariable): bool { - if ($someVariable !== 'a' && $someVariable !== 'b' && $someVariable !== 'c') { + if (! in_array($someVariable, ['a', 'b', 'c']), true) { return true; } return false; }