Skip to content

[CodeQuality] Skip with HTML on ShortenElseIfRector #7686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Nov 29, 2025
Merged

[CodeQuality] Skip with HTML on ShortenElseIfRector #7686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
110b0ea
[CodeQuality] Skip with HTML on ShortenElseIfRector
samsonasik Nov 29, 2025
3fd5993
[ci-review] Rector Rectify
actions-user Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions rules-tests/CodeQuality/Rector/If_/ShortenElseIfRector/Fixture/skip_with_html.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?php

namespace Rector\Tests\CodeQuality\Rector\If_\ShortenElseIfRector\Fixture;

class SkipWithHTML
{
private function renderMenu(): void {
?>
<div>
<?php if ($menuItem->is_main_item) : ?>
<a href="#" class="<?= $aClass ?>">
<div class="flex items-center gap-2 pointer-events-none">
<?= $menuItem->icon ? $this->Icon->render($menuItem->icon) : '' ?>
<?= $title ?>
</div>
</a>
<?php else :
if ($menuItem->is_external_url) {
echo $this->Html->link($title, $menuItem->url, [
'menu-icon' => $menuItem->icon ?? false,
'class' => $aClass,
]);
} elseif ($menuItem->parsed_url && $menuItem->is_url_valid) {
echo $this->Html->linkFromPath($title, $menuItem->parsed_url, [], [
'menu-icon' => $menuItem->icon ?? false,
'class' => $aClass,
]);
} else {
// Do something?
}
endif; ?>
</div>
<?php
}
}
1 change: 1 addition & 0 deletions rules/CodeQuality/Rector/FuncCall/SortNamedParamRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ public function refactor(Node $node): ?Node
if ($node instanceof CallLike && $node->isFirstClassCallable()) {
return null;
}

$args = $node instanceof Attribute ? $node->args : $node->getArgs();

if (count($args) <= 1) {
Expand Down
3 changes: 2 additions & 1 deletion rules/CodeQuality/Rector/If_/ShortenElseIfRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use PhpParser\Node\Stmt\ElseIf_;
use PhpParser\Node\Stmt\If_;
use PhpParser\Node\Stmt\Nop;
use Rector\Contract\Rector\HTMLAverseRectorInterface;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
Expand All @@ -17,7 +18,7 @@
/**
* @see \Rector\Tests\CodeQuality\Rector\If_\ShortenElseIfRector\ShortenElseIfRectorTest
*/
final class ShortenElseIfRector extends AbstractRector
final class ShortenElseIfRector extends AbstractRector implements HTMLAverseRectorInterface
{
public function getRuleDefinition(): RuleDefinition
{
Expand Down