Skip to content

[DeadCode] Skip on object with __destruct method on RemoveUnusedVariableAssignRector #7711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 2 commits into from
Dec 3, 2025
Merged

[DeadCode] Skip on object with __destruct method on RemoveUnusedVariableAssignRector #7711

TomasVotruba merged 2 commits into from
Dec 3, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 3, 2025

@samsonasik
Copy link
Member Author

samsonasik commented Dec 3, 2025

Fixed 🎉 /cc @lyrixx

@samsonasik
Copy link
Member Author

samsonasik commented Dec 3, 2025

@TomasVotruba ready 👍

lyrixx
lyrixx reviewed Dec 3, 2025
View reviewed changes
Copy link
Contributor

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TomasVotruba TomasVotruba merged commit 538dfac into main Dec 3, 2025
55 checks passed
@TomasVotruba TomasVotruba deleted the skip-des branch December 3, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

+1 more reviewer

@lyrixx lyrixx lyrixx left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not remove var assignation when reference object that implement __destruct()

5 participants

@samsonasik @lyrixx @TomasVotruba @actions-user