Remove setAttribute() from Rector rules, where not suitable + add phpstan rule to help separate to DecoratingNodeVisitors #7738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-decouple-attributes
branch
2 times, most recently
from
a34259c to
34fdc93
Compare
TomasVotruba
force-pushed
the
tv-decouple-attributes
branch
from
34fdc93 to
57bb816
Compare
samsonasik
reviewed
Dec 18, 2025
| if ($comments !== []) { | ||
| $this->mirrorComments($arrowFunction->expr, $node->stmts[0]); | ||
| $arrowFunction->setAttribute(AttributeKey::COMMENT_CLOSURE_RETURN_MIRRORED, true); | ||
| $arrowFunction->setAttribute(AttributeKey::COMMENTS, true); |
Member
There was a problem hiding this comment.
@TomasVotruba this seems cause crash as will cause ->getComments() that returns comments attribute that has array native return, see issue:
Member
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.