Skip to content

fix: chained calls on static calls #7746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Dec 9, 2025
Merged

fix: chained calls on static calls #7746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .../ArrowFunctionDelegatingCallToFirstClassCallableRector/Fixture/skip_chained_calls.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@ final class SkipChainedCalls
{
public function run()
{
function ($foo)
{
return FooBar::foo()->bar($foo);
};

fn ($foo) => FooBar::foo()->bar($foo);
fn ($foo) => FooBar::foo()::bar($foo);
}
}
8 changes: 5 additions & 3 deletions rules/CodingStyle/Guard/ArrowFunctionAndClosureFirstClassCallableGuard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,13 @@ private function isUsingNamedArgs(array $args): bool

private function isChainedCall(FuncCall|MethodCall|StaticCall $callLike): bool
{
if (! $callLike instanceof MethodCall) {
return false;
if ($callLike instanceof MethodCall) {
return $callLike->var instanceof CallLike;
} elseif ($callLike instanceof StaticCall) {
return $callLike->class instanceof CallLike;
}

return $callLike->var instanceof CallLike;
return false;
}

/**
Expand Down