Skip to content

[NodeVisitor] Avoid reflection lookup when there is no Closure/ArrowFunction in Arg value in ClosureWithVariadicParametersNodeVisitor #7756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samsonasik wants to merge 1 commit into from
Closed

[NodeVisitor] Avoid reflection lookup when there is no Closure/ArrowFunction in Arg value in ClosureWithVariadicParametersNodeVisitor #7756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions src/PhpParser/NodeVisitor/ClosureWithVariadicParametersNodeVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Rector\PhpParser\NodeVisitor;

use PhpParser\Node\Arg;
use PhpParser\Node;
use PhpParser\Node\Expr\ArrowFunction;
use PhpParser\Node\Expr\CallLike;
Expand Down Expand Up @@ -37,32 +38,38 @@ public function enterNode(Node $node): ?Node
return null;
}

if ($node->getArgs() === []) {
$args = $node->getArgs();
if ($args === []) {
return null;
}

$methodReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($node);
$filteredArgs = array_filter(
$args,
fn (Arg $arg): bool => $arg->value instanceof Closure || $arg->value instanceof ArrowFunction
);

foreach ($node->getArgs() as $arg) {
if (! $arg->value instanceof Closure && ! $arg->value instanceof ArrowFunction) {
continue;
}
if ($filteredArgs === []) {
return null;
}

$methodReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($node);
Copy link
Member

@TomasVotruba TomasVotruba Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optimization should happen inside this method.

Otherwise the performance is reduced when it's called from different place.

Copy link
Member Author

@samsonasik samsonasik Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this PR is to avoid reflection lookup when possible on every call like, since the attribute flag filling is only when argument is closure/arrow function.

The method is general method that used in various places and imo already optimized.


foreach ($filteredArgs as $filteredArg) {
if ($methodReflection instanceof NativeFunctionReflection) {
$parametersAcceptors = ParametersAcceptorSelector::combineAcceptors(
$methodReflection->getVariants()
);

foreach ($parametersAcceptors->getParameters() as $extendedParameterReflection) {
if ($extendedParameterReflection->getType() instanceof CallableType && $extendedParameterReflection->getType() ->isVariadic()) {
$arg->value->setAttribute(AttributeKey::HAS_CLOSURE_WITH_VARIADIC_ARGS, true);
$filteredArg->value->setAttribute(AttributeKey::HAS_CLOSURE_WITH_VARIADIC_ARGS, true);
}
}

return null;
}

$arg->value->setAttribute(AttributeKey::HAS_CLOSURE_WITH_VARIADIC_ARGS, true);
$filteredArg->value->setAttribute(AttributeKey::HAS_CLOSURE_WITH_VARIADIC_ARGS, true);
}

return null;
Expand Down