[ChangesReporting][Alternative] Collect changed_files on --no-diffs with json output with use of JsonOutputFactory #7821
+151
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
samsonasik
force-pushed
the
use-factory
branch
2 times, most recently
from
0a2abd2 to
8f69825
Compare
Member
Author
|
@peterfox on running via cli, it somehow not show the list of file changed (even your original PR). ➜ rector-src git:(use-factory) ✗ bin/rector process src/Application/VersionResolver.php --output-format=json --no-diffs --dry-run
{
"totals": {
"changed_files": 1,
"errors": 0
}
}so it seems need change on I will look more, mark as draft for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make easy test for cross OS usage.
Continue of PR:
Closes #7808