Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring log format by removing metadata addition in log statements. #4220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AmarnatReddy
Copy link
Contributor

@AmarnatReddy AmarnatReddy commented Nov 13, 2024

Description

Refactoring log format by removing metadata addition in log statements.

Older Log format :
2024-11-13 01:20:29,417 (cephci.utility.xunit) [INFO] - cephci.run.py:504 - RPM Compose source - https://s3.upshift.redhat.com/ceph-composes/RHCEPH-8.0-RHEL-9-20241030.0/RHCEPH-8.0-RHEL-9-20241030.0.repo

New log Format:
2024-11-13 13:46:47,424 (root) [INFO] run - [Thread MainThread] - run:504 - RPM Compose source - https://s3.upshift.redhat.com/ceph-composes/RHCEPH-8.0-RHEL-9-20241030.0/RHCEPH-8.0-RHEL-9-20241030.0.repo

The new format includes thread information, making it easier to identify logs from specific threads when multithreading is in use. If threads are named, the thread name will be displayed in the format [Thread <thread_name>]. This enhancement improves log readability in concurrent executions.

Please include Automation development guidelines. Source of Test case - New Feature/Regression Test/Close loop of customer BZs

click to expand checklist
  • Create a test case in Polarion reviewed and approved.
  • Create a design/automation approach doc. Optional for tests with similar tests already automated.
  • Review the automation design
  • Implement the test script and perform test runs
  • Submit PR for code review and approve
  • Update Polarion Test with Automation script details and update automation fields
  • If automation is part of Close loop, update BZ flag qe-test_coverage “+” and link Polarion test

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AmarnatReddy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@psathyan psathyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmarnatReddy thanks for taking the initiative on fixing the logging.

if I understand correctly, we decided to remove this entire file.

@psathyan
Copy link
Contributor

Thanks @AmarnatReddy for the explanation.

This is good approach and the modification effort is minimal. Let's evaluate parallel.

if it is working, we should be able to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants