inventory file update : jdk or oathtool #4348
Conversation
manisha-reddem
requested review from
mkasturi18,
ckulal,
TejasC88 and
a team
as code owners
|
|
||
| extra-packages: | ||
| jdk: | ||
| url: wget https://download.oracle.com/java/23/latest/jdk-23_linux-x64_bin.rpm | ||
| oathtool: | ||
| url: https://dl.fedoraproject.org/pub/epel/9/Everything/x86_64/Packages/o/oathtool-2.6.12-1.el9.x86_64.rpm |
There was a problem hiding this comment.
Can this be driven through test input as it is specific to a test suite or group?
There was a problem hiding this comment.
Yes, we can specify the package names we need to install in the test suite, and based on the test input, it will install the required package versions from the inventory file.
There was a problem hiding this comment.
IMHO, we should not be using inventory file. It should be part of the test configuration. Keeping it test configuration allows us to keep the test idempotent.
There was a problem hiding this comment.
I think this fix stems from this comment #4186 (comment)... there I have mentioned installing the required packages via runcmd and not a separate key. Let's chat offline
tests/rgw/sanity_rgw.py
Outdated
| @@ -116,14 +116,27 @@ def run(ceph_cluster, **kw): | |||
| # install extra package which are test specific | |||
| if extra_pkgs: | |||
| log.info(f"got extra pkgs: {extra_pkgs}") | |||
| inventory_data = config.get("inventory") | |||
There was a problem hiding this comment.
This creates a dependency on virtual environment. The tests should be agonistic of the platform used for deploying the test environment.
There was a problem hiding this comment.
We can ensure that the required packages are added to all environments, making the test environment platform-independent.
manisha-reddem
force-pushed
the
feature/rgw
branch
from
5d2d385 to
f1f7013
Compare
Signed-off-by: Reddem Manisha <[email protected]>
manisha-reddem
force-pushed
the
feature/rgw
branch
from
f1f7013 to
a214d01
Compare
manisha-reddem
added
DNM
| @@ -0,0 +1,53 @@ | |||
| --- | |||
There was a problem hiding this comment.
generalizing the name may be a bit difficult instead opt to use rhel-9.5.0-x86_64-rgw.yaml
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: manisha-reddem, psathyan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Centralize package versions (e.g., JDK, oathtool) in an inventory to simplify updates across suites.
log: http://magna002.ceph.redhat.com/ceph-qe-logs/mreddem/cephci-run-BLWG2P/Test_BucketNotification_with_users_in_same_tenant_and_different_tenant_0.log - for jdk package
log: http://magna002.ceph.redhat.com/ceph-qe-logs/mreddem/cephci-run-IP5QZM/multipart_versioned_object_deletion_with_mfa_token_0.log - for oathtool package
issue: https://issues.redhat.com/browse/RHCEPHQE-16965