Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Automation:CEPH-83595961 #4359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test Automation:CEPH-83595961 #4359

wants to merge 1 commit into from

Conversation

chaitanyadommeti
Copy link

Description

Success log: http://magna002.ceph.redhat.com/ceph/cephci-jenkins/cephci-run-WC9LMF/

@chaitanyadommeti chaitanyadommeti added the RBD Rados Bock Device label Jan 7, 2025
sunilangadi2
sunilangadi2 reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@sunilangadi2 sunilangadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Looks good.

suites/squid/rbd/tier-3_rbd_migration.yaml Show resolved Hide resolved
sunilangadi2
sunilangadi2 previously approved these changes Jan 9, 2025
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jan 9, 2025
@sunilangadi2 sunilangadi2 self-requested a review January 13, 2025 11:37
@openshift-ci openshift-ci bot removed the lgtm Add this label when the PR is good to be merged label Jan 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chaitanyadommeti

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chaitanyadommeti

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chaitanyadommeti
Copy link
Author

chaitanyadommeti commented Jan 17, 2025 •
edited
Loading

Success log after implementing review comments:
http://magna002.ceph.redhat.com/ceph/cephci-jenkins/cephci-run-1L1UNZ/

Addressed review comment
3e0c5dc 
Signed-off-by: Chaitanya Dommeti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunilkumarn417 sunilkumarn417 Awaiting requested review from sunilkumarn417

@aarsharm aarsharm Awaiting requested review from aarsharm

@Manohar-Murthy Manohar-Murthy Awaiting requested review from Manohar-Murthy Manohar-Murthy is a code owner

@sunilangadi2 sunilangadi2 Awaiting requested review from sunilangadi2

At least 1 approving review is required to merge this pull request.

Assignees

@sunilangadi2 sunilangadi2

Labels
RBD Rados Bock Device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaitanyadommeti @sunilangadi2