Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV workload with Discovered Apps #10616

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

CNV workload with Discovered Apps #10616

wants to merge 9 commits into from

Conversation

prsurve
Copy link
Contributor

@prsurve prsurve commented Oct 4, 2024

No description provided.

@prsurve prsurve added DR Metro and Regional DR related PRs Squad/Turquoise labels Oct 4, 2024
@prsurve prsurve requested a review from a team October 4, 2024 08:06
@prsurve prsurve requested a review from a team as a code owner October 4, 2024 08:06
@prsurve prsurve added the Verified Mark when PR was verified and log provided label Oct 7, 2024
am-agrawa
am-agrawa reviewed Oct 14, 2024
View reviewed changes
ocs_ci/ocs/dr/dr_workload.py Outdated Show resolved Hide resolved
ocs_ci/ocs/dr/dr_workload.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
...s/functional/disaster-recovery/regional-dr/test_cnv_failover_and_relocate_discovered_apps.py Show resolved Hide resolved
am-agrawa
am-agrawa previously approved these changes Nov 7, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Nov 7, 2024
@sidhant-agrawal
Copy link
Contributor

@prsurve Can you please run verification via Multicluster job once?

@openshift-ci openshift-ci bot removed the lgtm label Nov 10, 2024
@prsurve
Copy link
Contributor Author

prsurve commented Nov 10, 2024

@prsurve Can you please run verification via Multicluster job once?

Verified here: https://url.corp.redhat.com/dc2a9d9

@openshift-ci openshift-ci bot added the lgtm label Nov 11, 2024
am-agrawa
am-agrawa previously approved these changes Nov 11, 2024
View reviewed changes
keemano
keemano previously approved these changes Nov 12, 2024
View reviewed changes
@prsurve
Fix typo
3b437bf 
Signed-off-by: prsurve <[email protected]>
@prsurve
Add rdr marker
4e4fb3c 
Signed-off-by: prsurve <[email protected]>
@prsurve
Resovle Comments and add polarion id
0faf7ef 
Signed-off-by: prsurve <[email protected]>
@prsurve
Remove unused import
147bd6c 
Signed-off-by: prsurve <[email protected]>
@prsurve
Remove force flag
3349f31 
Signed-off-by: prsurve <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Nov 14, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 14, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prsurve

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

3 similar comments
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prsurve

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prsurve

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prsurve

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebenahar ebenahar ebenahar left review comments

@keemano keemano keemano left review comments

@am-agrawa am-agrawa am-agrawa left review comments

@sidhant-agrawal sidhant-agrawal sidhant-agrawal left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@sidhant-agrawal sidhant-agrawal

@am-agrawa am-agrawa

@keemano keemano

Labels
DR Metro and Regional DR related PRs size/XL Squad/Turquoise Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prsurve @sidhant-agrawal @ebenahar @am-agrawa @keemano