Skip to content

update storageconsumer api for centralising distribution and making it user facing #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Feb 26, 2025

new fields with *Classes are intended to be filled by storage admin for distributing to connected client cluster that the storageconsumer represents. Only name is specified and later will be expanded if more config is required.

configmapref name if provided will be owned by corresponding consumer and reconciled by the consumer controller or else will be created by controller and same will be reflected in the consumer status.

@leelavg
Copy link
Contributor Author

leelavg commented Mar 5, 2025

/hold

Will squash after final review

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2025
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leelavg
Copy link
Contributor Author

leelavg commented Mar 19, 2025

rebased.

@leelavg leelavg force-pushed the consumer-api branch 2 times, most recently from db76333 to da8e5eb Compare March 20, 2025 05:59
Signed-off-by: Leela Venkaiah G <[email protected]>
@leelavg leelavg force-pushed the consumer-api branch 2 times, most recently from 0d863b8 to c85527f Compare March 20, 2025 14:58
@nb-ohad
Copy link
Contributor

nb-ohad commented Mar 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
@nb-ohad
Copy link
Contributor

nb-ohad commented Mar 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
Copy link
Contributor

openshift-ci bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg
Copy link
Contributor Author

leelavg commented Mar 20, 2025

/retest

@leelavg
Copy link
Contributor Author

leelavg commented Mar 20, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7a408e9 into red-hat-storage:main Mar 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants