220 - Blocking resources #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/domain page. Also fixed an unwanted gap in the tags by putting the 'New!' tag at the end
…e-solutions/stalker into feature/149-disable-subscriptions
Aboisier
approved these changes
Mar 25, 2024
packages/backend/jobs-manager/service/src/modules/database/reporting/host/host-filter.model.ts
Outdated
Show resolved
Hide resolved
packages/backend/jobs-manager/service/src/modules/database/reporting/host/host.dto.ts
Outdated
Show resolved
Hide resolved
packages/frontend/stalker-app/src/app/modules/domains/list-domains/list-domains.component.ts
Outdated
Show resolved
Hide resolved
packages/frontend/stalker-app/src/app/modules/domains/view-domain/view-domain.component.ts
Outdated
Show resolved
Hide resolved
packages/frontend/stalker-app/src/app/modules/hosts/list-hosts/list-hosts.component.ts
Outdated
Show resolved
Hide resolved
packages/frontend/stalker-app/src/app/modules/hosts/view-host/view-host.component.ts
Outdated
Show resolved
Hide resolved
packages/frontend/stalker-app/src/app/modules/hosts/view-port/view-port.component.ts
Outdated
Show resolved
Hide resolved
packages/frontend/stalker-app/src/app/modules/ports/list-ports/list-ports.component.ts
Outdated
Show resolved
Hide resolved
Feature/149 menus
…ubscriptions Feature/149 disable subscriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing:
Closes #220
Now possible to block a resource so that it is not used in any subscription, cron or event. It allows for remembering a resource, but not scanning/probing them again.
The PR introduces the "is" filter for resources, where you can specify a boolean. The only supported boolean right now is "blocked. "is: blocked" represents true, "-is: blocked" represents false.
The UI, when blocking a resource, will always confirm with the user that they really want to block/unblock a resource.
I chose to not delete the data of a resource when blocked. It makes more sense to remember what they had, for future reference and for unblocking.
By default, the page is filtered by "-is: blocked" to only show items that are not blocked.
You can block in the list resources page:
You can block in the view-resource page:
A blocked resource shows that it is blocked by adding the panel section "Blocked" with the timestamp.
