-
Notifications
You must be signed in to change notification settings - Fork 315
KFLUINFRA-2666: macos values in host-config chart #9489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
KFLUINFRA-2666: macos values in host-config chart #9489
Conversation
… into staging host-values' host-values.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: meyrevived The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🤖 Gemini AI Assistant AvailableHi @meyrevived! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
|
🤖 Hi @meyrevived, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
/retest |
| dynamic.macos-mac2metal-arm64.ami: {{ default (index $amd "ami") $config.ami | quote }} | ||
| dynamic.macos-mac2metal-arm64.instance-type: {{ (index $config "instance-type") | default "mac2metal" | quote }} | ||
| dynamic.macos-mac2metal-arm64.instance-tag: {{ (index $config "instance-tag") | default (printf "%s-arm64-mac2metal" $environment) | quote }} | ||
| dynamic.macos-mac2metal-arm64.key-name: {{ default (index $amd "key-name") ((index $config "key-name")) | quote }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirm it is supposed to use amd profile defaults?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand the question. Podman Desktop people specifically requested Apple Silicone machines, which are arm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean:
(index $amd "key-name")
(index $amd "ami")
will be taken from the amd default settings in values.yaml, i.e. from:
amd64:
ami: "ami-01aaf1c29c7e0f0af"
key-name: "konflux-stage-ext-mab01"
security-group-id: "sg-05bc8dd0b52158567"
subnet-id: "subnet-030738beb81d3863a"
Add macos host config values in host-config chart and into staging host-values' host-values.