Skip to content

Conversation

@hugares
Copy link
Contributor

@hugares hugares commented Dec 5, 2025

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🤖 Gemini AI Assistant Available

Hi @hugares! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🤖 Hi @hugares, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.


macos-arm64:
ami: "ami-000ce2c23b96216d3"
key-name: "packer-key"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the config I received from Manish, I still need to figure out what is this key-name and if we need to extract an additional ssh key secret for mac or if we are using same one as linux ec2 instances...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key will be the same as other linux nodes for that we are using for stage-p01 cluster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this key-name: "packer-key" then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so should I put this back to konflux-stage-int-mab01, i.e. same as other amd and arm ec2 config

Add support for macos in helm template and add first configuration of
macos in stone-stage-p01.

Signed-off-by: Hugo Ares <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@filariow
Copy link
Member

filariow commented Dec 5, 2025

We need to double check that it ends up in host-config as macos/whatever, the forward slash is required by MPC.
I'd also suggest adding the arch version (M2, M2-metal, M3, etc).
If we need to support different versions of the OS, it would be good to have that info too in the name (eg sequoia, ...)

@hugares
Copy link
Contributor Author

hugares commented Dec 5, 2025

We need to double check that it ends up in host-config as macos/whatever, the forward slash is required by MPC. I'd also suggest adding the arch version (M2, M2-metal, M3, etc). If we need to support different versions of the OS, it would be good to have that info too in the name (eg sequoia, ...)

I just saw that @meyrevived already opened one PR about this, I will close this one and comment on the one she opened: #9489

@hugares hugares closed this Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants