Add notification icon button to navbar #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitCohen2
force-pushed
the
addNotificationButton
branch
from
0e94453 to
3052fb6
Compare
|
83667736-259D-4194-BFF3-94E82CD72CFB.MP4Please take a look and tell me what do you think about it |
|
I think it's looks great !! Well Done !! |
|
I've added these changes to my PR. Can you close this one? |
|
This added already in #111 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Add notification bell button with number of notifications to the navbar.
It is only displayed when a user is logged in.
Implemented Changes
Connected Issue/Story
Resolves #113
Dependencies
This section inidicates whether this PR depends on any other PR's.
Might need to wait for other PR's to merged before. Add the PR ID.
changes
Test coverage
Documentation