Fix 6 workload bugs found during EE sweep testing - #9865
Open
rhjcd wants to merge 2 commits into
Open
Conversation
- containerlab: remove stray wget prefix and trailing quote from RPM URL
- control-user: guard report-user-data on control_user_password defined
- host-ocp4-installer: only emit cpuPartitioningMode when defined
- ansible-bu-workshop: disable become on localhost workloads play
- gitea-operator: bump catalog image tag v2.0.1 to v2.3.2
- showroom: guard certbot_cert_manager_* fallback vars with default('')
ansible-core 2.19 introduces _AnsibleTaggedStr which breaks json.dumps() calls. Adding default=str allows serialization of these tagged string types without data loss.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 6 independent workload bugs discovered during EE image migration testing across the RHDP catalog.
ansible/roles/containerlab/tasks/main.yml): RPM download URL had a straywgetprefix and trailing quote, causingget_urlto failansible/roles/control-user/tasks/report-user-data.yml):report-user-datatask failed whencontrol_user_passwordwas not defined — addedwhenguardansible/roles/host-ocp4-installer/templates/install-config.yaml.j2):cpuPartitioningModewas unconditionally emitted with a default ofNone, causing validation failures on older OCP versions — now only emitted when explicitly definedansible/configs/ansible-bu-workshop/workloads.yml): localhost workloads play hadbecome: truewhich fails on localhost — changed tobecome: falseansible/roles_ocp_workloads/ocp4_workload_gitea_operator/defaults/main.yml): catalog image tag pinned to stalev2.0.1— bumped tov2.3.2ansible/roles/showroom/templates/base_service_traefik_httpd/base_service_traefik_httpd.j2):certbot_cert_manager_*fallback variables in Jinja2default()filters were undefined when showroom was used standalone — wrapped each with| default('')Jira