Fix showroom iframe quote and URL scheme for port 80 - #9895
Merged
bbethell-1 merged 2 commits intoAug 3, 2026
Conversation
The template had src="./{{ showroom_component_name }}/"index.html"
which produces a broken HTML attribute. Remove the extra quote so
the iframe correctly loads the Antora content.
rhjcd
changed the title
The verify task hardcoded https:// in lab_ui_url. When showroom_primary_port is 80 and TLS is disabled, this produced https://host:80/showroom/ which is broken. Compute the scheme from the port: port 80 -> http, else https. Also suppress the :80 and :443 port suffixes since they are defaults for their respective schemes.
rhjcd
force-pushed
the
fix/showroom-template-iframe-quote
branch
from
August 2, 2026 02:58
fee4a5e to
9ecc125
Compare
bbethell-1
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.html.j2iframe src attribute (line 18) that caused 404 errors60-showroom-verify.ymlto usehttp://scheme whenshowroom_primary_portis 80, instead of hardcodinghttps://:80for http,:443for https) inlab_ui_urlNeeded for
rhel-podman-desktopcatalog item which runs showroom on bastion via podman (port 80, no TLS) alongside noVNC on port 443.