Fedora based Asciidoctor #605
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| runs-on: ubuntu-18.04 | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Check and verify version.json |
There was a problem hiding this comment.
this step can be released by the central action. see:
There was a problem hiding this comment.
Sorry, not making it easier for review.
| ./${{ env.context }}/Dockerfile | ||
| image: ${{ env.image_name }} | ||
| tags: "${{ steps.image_tags.outputs.IMAGE_TAGS }}" | ||
| - name: Push to Quay |
There was a problem hiding this comment.
i'd add in the ghcr push as well, like:
allows forks to then test a built image without them needing access or setup of quay creds.
Update to latest asciidoctor Update to latest asciidoctor Update latest ubi8 and pandoc Fedora based asciidoctor Correcting for PR comments
|
Sorry, not making review easier. |
| id: image_tags | ||
| uses: redhat-cop/github-actions/get-image-version@master | ||
| with: | ||
| IMAGE_CONTEXT_DIR: ${{ env.CONTEXT_DIR }} |
There was a problem hiding this comment.
env CONTEXT_DIR should be context based on line 10
| id: image_tags | ||
| uses: redhat-cop/github-actions/get-image-version@master | ||
| with: | ||
| IMAGE_CONTEXT_DIR: ${{ env.CONTEXT_DIR }} |
There was a problem hiding this comment.
same as other comment, wrong env name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR About?
Describe the contents of the PR
Actually, a copy of ubi8-asciidoctor but now Fedora (fc) based.
This image is easier to maintain because version dependencies are handled by Fedora team
How do we test this?
Provide commands/steps to test this PR.
Create a pdf
And check this pdf with pdf generated by ubi8-asciidoctor
That worked out fine.
Newer versions can have another test cycle.
cc: @redhat-cop/day-in-the-life