fix: address PR #76 review comments - #125
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Critical: - Fix mismatched thinking-tag regex in ChatMessagesView - Clear refresh interval after 401 in useRefreshableToken Major: - Await server deletion results before showing success in ProfileSection - Move getStreamingManager out of render into useEffect - Ensure resumeInterrupt promise settles on error/cancellation Security & hardening: - Add CI workflow permissions and persist-credentials: false - Reject prototype keys in deepMerge - Escape agentName in HTML title - Validate x-trace-id against safe charset Minor fixes: - Tailwind v4 important syntax across 5 files - A11y: live regions, ARIA roles, main landmark - Guard clipboard, popup, sessionStorage, stream updates - Fix rate limit timer drift, sidebar search reset, empty rename - Move QUICK_PROMPTS inside component, default dark theme - Rename keyframes to kebab-case, extend CSS focus selectors - Docs: language tags, hot-reload, auth docs, shell exports - Add Node.js >=22.13.0 engine requirement Signed-off-by: Soham Dutta <19648293+NP-compete@users.noreply.github.com>
NP-compete
force-pushed
the
fix/pr-76-review-comments
branch
from
August 12, 2026 13:20
688ba8a to
c82a3e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126
Summary
Critical
<think>/</redacted_thinking>regex in ChatMessagesViewMajor
getStreamingManagerout of render into useEffect (no side effects during render)resumeInterruptpromise settles on error/cancellationSecurity & Hardening
permissions: contents: readandpersist-credentials: false__proto__,constructor,prototype) indeepMergeagentNamebefore HTML interpolation in client routerx-trace-idheader against safe charset and max lengthMinor
!utility→utility!) across 5 files<main>landmark, removed conflicting aria-label>=22.13.0engine requirementTest plan
npm run lint— 0 errorsnpx tsc --noEmit— cleannpm test— 253/253 passednpm run build— successful (frontend + server)