Skip to content

fix: add minicore_disabled build tag to Makefile targets - #324

Closed
Umme-2003 wants to merge 1 commit into
redhat-data-and-ai:mainfrom
Umme-2003:fix/makefile-minicore-disabled
Closed

fix: add minicore_disabled build tag to Makefile targets#324
Umme-2003 wants to merge 1 commit into
redhat-data-and-ai:mainfrom
Umme-2003:fix/makefile-minicore-disabled

Conversation

@Umme-2003

Copy link
Copy Markdown
Contributor

Fixes the local build issue on macOS ARM by adding -tags minicore_disabled.

Related to #137.

The Snowflake Go driver requires a platform-specific .dylib that is not
available on macOS ARM. Adding -tags minicore_disabled to vet, build, run,
and test targets allows local development on Apple Silicon.
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 52645720-403b-4d5b-9af8-12e0a8f18198

📥 Commits

Reviewing files that changed from the base of the PR and between 5a86b26 and 92c455e.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated test commands to use the minicore_disabled build configuration while continuing to exclude end-to-end packages and generate coverage reports.
  • Build & Validation
    • Updated vetting, build, and run commands to consistently use the same build configuration.

Walkthrough

The Makefile now passes the minicore_disabled build tag to Go vet, test, build, and run commands, including manager build and host-run recipes. Test exclusion and coverage behavior remain unchanged.

Changes

Minicore-disabled build commands

Layer / File(s) Summary
Update Go command recipes
Makefile
Go vet, test, build, and run recipes now include the minicore_disabled build tag. Manager build and host-run recipes use the same tag. Test execution still excludes /e2e packages and generates coverage output.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: concaf, gshikhar2021

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the macOS ARM build issue and the minicore_disabled fix.
Title check ✅ Passed The title clearly identifies the Makefile change and the minicore_disabled build tag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Umme-2003 Umme-2003 closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants