Skip to content

fix: return error when no accessible pipelines found in MCP list tool #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PuneetPunamiya merged 4 commits into from
Aug 21, 2026
Merged

fix: return error when no accessible pipelines found in MCP list tool #325

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0135d5e
fix: return error when no accessible pipelines found in list tool
umz2003 Aug 14, 2026
214cd7d
fix: return dedicated error when kubernetes client is nil
umz2003 Aug 14, 2026
d124496
Update internal/mcp/tools/list_pipelines.go
Umme-2003 Aug 17, 2026
35f61cf
fix: resolve lint errors (ineffassign, early-return)
umz2003 Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 38 additions & 16 deletions internal/mcp/tools/list_pipelines.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,23 +59,27 @@ If NONE match, tell the user. Do NOT try all pipelines.`,
}, nil, nil
}

pipelines := []k8sclient.PipelineInfo{}
if k8sClient != nil {
var err error
pipelines, err = k8sClient.ListPipelines(ctx)
if err != nil {
log.Error("failed to list pipelines from kubernetes", "error", err)
return &mcp.CallToolResult{
Content: []mcp.Content{&mcp.TextContent{
Text: fmt.Sprintf("Error listing pipelines: %v", err),
}},
IsError: true,
}, nil, nil
}
log.Info("listed pipelines from kubernetes", "count", len(pipelines))
} else {
log.Warn("kubernetes client is nil, skipping pipeline listing")
if k8sClient == nil {
log.Error("kubernetes client is not initialized")
return &mcp.CallToolResult{
Content: []mcp.Content{&mcp.TextContent{
Text: "Error: unable to connect to the cluster. Please contact your administrator.",
}},
IsError: true,
}, nil, nil
}

pipelines, err := k8sClient.ListPipelines(ctx)
if err != nil {
log.Error("failed to list pipelines from kubernetes", "error", err)
return &mcp.CallToolResult{
Content: []mcp.Content{&mcp.TextContent{
Text: fmt.Sprintf("Error listing pipelines: %v", err),
}},
IsError: true,
}, nil, nil
}
log.Info("listed pipelines from kubernetes", "count", len(pipelines))

databases, err := snowflake.ShowDatabases(ctx, oauthToken)
if err != nil {
Expand All @@ -102,6 +106,24 @@ If NONE match, tell the user. Do NOT try all pipelines.`,
}
}

if len(accessible) == 0 {
if len(pipelines) == 0 {
log.Info("no pipelines found in cluster")
return &mcp.CallToolResult{
Content: []mcp.Content{&mcp.TextContent{
Text: "No pipelines are configured in this cluster.",
}},
}, nil, nil
}
log.Info("no accessible pipelines found", "total_pipelines", len(pipelines))
return &mcp.CallToolResult{
Content: []mcp.Content{&mcp.TextContent{
Text: fmt.Sprintf("Found %d pipeline(s) but you do not have access to any of them. Please verify your access permissions.", len(pipelines)),
}},
IsError: true,
}, nil, nil
}

jsonBytes, err := json.Marshal(accessible)
if err != nil {
log.Error("failed to marshal result", "error", err)
Expand Down
Loading