fix(build): vendor Helm Go deps for hermetic Konflux builds - #282
Closed
nickboldt wants to merge 2 commits into
Closed
fix(build): vendor Helm Go deps for hermetic Konflux builds#282nickboldt wants to merge 2 commits into
nickboldt wants to merge 2 commits into
Conversation
Konflux hermetic builds source cachi2.env with GOPROXY=file:// and no network access during RUN. Building Helm from vendor/helm without vendored external modules caused go build to fail resolving imports (e.g. helm.sh/helm/v4/internal/plugin/cache). Run go mod tidy and go mod vendor after pruning Helm source, commit the vendor tree, and build with -mod=vendor in both Containerfiles so all dependencies are available offline. https://redhat.atlassian.net/browse/RHIDP-16046 Generated-by: cursor Co-authored-by: Cursor <cursoragent@cursor.com>
The troubleshooting step passed all_changed_files through an environment variable. Large vendor/helm/vendor/ diffs exceed the process argument limit and fail before the image build runs. Log the changed-file count and a 20-file git diff sample instead. https://redhat.atlassian.net/browse/RHIDP-16046 Generated-by: cursor Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
PR images are available (for 1 week):
|
nickboldt
marked this pull request as draft
August 12, 2026 12:19
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
6 tasks
Member
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vendor/helm/vendor/for offline/hermetic buildsgo mod tidy+go mod vendorinhack/update-vendor.shafter pruning Helm source-mod=vendorin upstream and downstream Containerfilesvendor/helm/go.mod(drops test-only requires)Fixes Konflux/cachi2 build failure where
go buildcould not resolve imports withGOPROXY=file://and no network during RUN.Ref: https://redhat.atlassian.net/browse/RHIDP-16046
Test plan
podman build --target helm-builder -f Containerfile .succeedsGOPROXY=off go build -mod=vendor ./cmd/helminvendor/helmsucceedsGenerated-by: cursor