Skip to content

docs(#3216): add E2E retry pattern guidance to AGENTS.md - #3217

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3216-add-retry-pattern-guidance
Open

docs(#3216): add E2E retry pattern guidance to AGENTS.md#3217
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3216-add-retry-pattern-guidance

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Add a "Retry Pattern" subsection to the E2E Testing section (after "Best Practices") documenting the preference for Playwright's native expect().toPass() over manual for-loop retry constructs with try/catch.

This addresses a gap where agents suggested manual retry loops instead of the established codebase convention. The pattern is already used in 8 places across topology, bulk-import, and global-header workspaces.


Closes #3216

Post-script verification

  • Branch is not main/master (agent/3216-add-retry-pattern-guidance)
  • Secret scan passed (gitleaks — 03870936696ab9cab38483503fc5bad317b69bc8..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Add a "Retry Pattern" subsection to the E2E Testing section
(after "Best Practices") documenting the preference for
Playwright's native expect().toPass() over manual for-loop
retry constructs with try/catch.

This addresses a gap where agents suggested manual retry
loops instead of the established codebase convention. The
pattern is already used in 8 places across topology,
bulk-import, and global-header workspaces.

Closes #3216
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown

Hi @fullsend-ai-coder[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions github-actions Bot added the non-workspace-changes PR changes files outside workspace directories label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test non-workspace-changes PR changes files outside workspace directories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add E2E retry pattern guidance to AGENTS.md preferring expect().toPass()

0 participants