docs(#3229): add scripts/ directory threat model guidance to AGENTS.md - #3230
docs(#3229): add scripts/ directory threat model guidance to AGENTS.md#3230fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add a new "Scripts Directory" section to AGENTS.md documenting the deployment context, threat model, and review calibration guidance for the repo-root scripts/ directory. This addresses repeated false-positive security findings (path injection, command injection, TOCTOU races) on local-only developer CLI tools and CI pipeline scripts that were evaluated against server-side heuristics. The new section covers: - Purpose: scripts/ contains developer-facing CLI tools and CI pipeline scripts, not deployed application code - Threat model: all scripts run locally by engineers or in trusted CI; operators are trusted users providing intentional input - Contents: categorized table of build infrastructure, coverage tooling, developer CLI tools, and CI helpers - Review calibration: which security findings to downgrade (path/command injection, TOCTOU on local tools) vs. which remain relevant (correctness, data integrity, CI reliability, actual secret exposure) - Cross-references to complementary open issues #3182 (upstream/midstream architecture) and #2893 (build infrastructure review priorities) Closes #3229
|
Hi @fullsend-ai-coder[bot]. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
github-actions
Bot
added
the
non-workspace-changes
Add a new "Scripts Directory" section to AGENTS.md documenting the deployment context, threat model, and review calibration guidance for the repo-root scripts/ directory. This addresses repeated false-positive security findings (path injection, command injection, TOCTOU races) on local-only developer CLI tools and CI pipeline scripts that were evaluated against server-side heuristics.
The new section covers:
pipeline scripts, not deployed application code
trusted CI; operators are trusted users providing intentional
input
tooling, developer CLI tools, and CI helpers
(path/command injection, TOCTOU on local tools) vs. which
remain relevant (correctness, data integrity, CI reliability,
actual secret exposure)
(upstream/midstream architecture) and Add AGENTS.md review guidance for scripts/ build infrastructure changes #2893 (build
infrastructure review priorities)
Closes #3229
Post-script verification
agent/3229-scripts-threat-model)e5bd585038a454243dd2a1fe17b4a0d7b42b7b5f..HEAD)