onboard keycloak auth provider plugin as dynamic - #3258
Conversation
|
🤖 Finished Review · ✅ Success · Started 6:50 PM UTC · Completed 6:56 PM UTC Commit: |
Review — Onboard Keycloak Auth Provider PluginVerdict: Approve SummaryThis PR onboards Changes verified
Observations (low severity)
Scope & coherence
Previous runReviewVerdict: approve This PR correctly onboards Verified
Notes
Previous run (2)Review — approveOnboard keycloak auth provider plugin as a dynamic plugin for RHDH 2.1 This PR correctly onboards CorrectnessVersion consistency — verified. All version references align:
Workspace artifacts — complete. All expected onboarding files are present:
Package metadata structure — valid. The new metadata file follows the established SecurityNo credentials or secrets exposed. The Observations
Previous run (3)ReviewVerdict: approve Clean, well-structured onboarding of What was verified
Observations (non-blocking)
Labels: PR onboards a new plugin package to the keycloak workspace |
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully. ✅ Published container images:
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
❌ These plugins failed to load: Error logs from container |
❌ Failed E2E Tests -
|
8f7937f to
7911c96
Compare
|
/smoketest |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully. ✅ Published container images:
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
|
/test e2e-ocp-helm |
❌ Failed E2E Tests -
|
7911c96 to
d7c83c0
Compare
|
🤖 Review · ❌ Terminated · Started 3:02 PM UTC · Ended 3:10 PM UTC Commit: |
|
/test e2e-ocp-helm |
|
🤖 Finished Review · ✅ Success · Started 3:02 PM UTC · Completed 3:10 PM UTC Commit: |
❌ Failed E2E Tests -
|
d7c83c0 to
7567dc1
Compare
|
/test e2e-ocp-helm |
|
🤖 Finished Review · ✅ Success · Started 4:08 PM UTC · Completed 4:14 PM UTC Commit: |
❌ Failed E2E Tests -
|
Signed-off-by: Jessica He <jhe@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
7567dc1 to
38b7df2
Compare
|
|
🤖 Review · ❌ Terminated · Started 1:38 PM UTC · Ended 1:43 PM UTC Commit: |
|
/test e2e-ocp-helm |
| lifecycle: active | ||
| partOf: | ||
| - backstage-community-plugin-auth-backend-module-keycloak-provider | ||
| appConfigExamples: |
There was a problem hiding this comment.
[low] conventions
partOf references the entity own name (backstage-community-plugin-auth-backend-module-keycloak-provider) rather than a logical group. Other packages use short group names (e.g. keycloak-catalog-integration, jenkins, adoption-insights).
Suggested fix: Use a logical group name such as keycloak-auth or align with the existing keycloak-catalog-integration group.
| @@ -1 +1,2 @@ | |||
| plugins/auth-backend-module-keycloak: | |||
| plugins/catalog-backend-module-keycloak: No newline at end of file | |||
There was a problem hiding this comment.
[low] style
File lacks a trailing newline (pre-existing issue, not introduced by this PR).
Suggested fix: Add a trailing newline to the file.
|
🤖 Finished Review · ✅ Success · Started 1:38 PM UTC · Completed 1:43 PM UTC Commit: |
✅ Passed E2E Tests -
|
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully. ✅ Published container images:
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
❌ These plugins failed to load: Error logs from container |
✅ Passed E2E Tests -
|



Summary
Fixes RHIDP-16098
Onboard auth backend provider modules as supported plugins (on BS 1.52.0). These were originally statically installed in RHDH core here, but for 2.1 we are decoupling them and provide ability to install them dynamically.
Changes
rhdh-supported-packages.txtentries, anddefault.packages.yaml(not OOTB enabled)Collateral changes