onboard pingfederate auth provider plugin as dynamic - #3259
Conversation
|
🤖 Finished Review · ✅ Success · Started 6:58 PM UTC · Completed 7:15 PM UTC Commit: |
Review — commentPR #3259 onboards the PingFederate auth backend provider module ( The PR follows the documented onboarding process for adding a new plugin to an existing workspace. The Findings1.
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully. ✅ Published container images:
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. No E2E tests available for this workspace. |
|
❌ These plugins failed to load: Error logs from container |
github-actions
Bot
added
mandatory-workspace
6ce343a to
65f02f8
Compare
|
🤖 Finished Review · ✅ Success · Started 9:19 PM UTC · Completed 9:24 PM UTC Commit: |
Superseded by updated review
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
added
the
requires-manual-review
github-actions
Bot
removed
workspace-update
|
/publish |
|
PR action ( |
65f02f8 to
5ddfb0e
Compare
Signed-off-by: Jessica He <jhe@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
5ddfb0e to
ab863a2
Compare
|
🤖 Review · Commit: |
|
/publish |
|
|
🤖 Review · ❌ Terminated · Started 2:51 PM UTC · Ended 3:03 PM UTC Commit: |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully. ✅ Published container images:
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. No E2E tests available for this workspace. |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
| lifecycle: active | ||
| partOf: | ||
| - backstage-community-plugin-auth-backend-module-pingfederate-provider | ||
| appConfigExamples: |
There was a problem hiding this comment.
[medium] correctness
The partOf field references the Package's own name instead of the parent Plugin entity group name. The sibling Package uses partOf: - pingidentity, matching the Plugin entity. A self-referential partOf breaks the plugin-to-package relationship in the extensions catalog.
Suggested fix: Change partOf from '- backstage-community-plugin-auth-backend-module-pingfederate-provider' to '- pingidentity' to match the Plugin entity name and sibling convention.
|
|
||
| # heading to GA per 11/12 meeting | ||
| pingidentity/plugins/catalog-backend-module-pingidentity | ||
| pingidentity/plugins/auth-backend-module-pingfederate-provider |
There was a problem hiding this comment.
[low] intent
The PR replaces catalog-backend-module-pingidentity with auth-backend-module-pingfederate-provider. The old plugin's metadata and default.packages.yaml entry remain as tech-preview, consistent with withdrawing the GA path while keeping it available. The PR description documents this as intentional.
fullsend-ai-review
Bot
added
requires-manual-review
|
🤖 Finished Review · ✅ Success · Started 2:51 PM UTC · Completed 3:03 PM UTC Commit: |
github-actions
Bot
added
the
mandatory-workspace
2 participants
Summary
Fixes RHIDP-16098
Onboard auth backend provider modules as supported plugins (on BS 1.52.0). These were originally statically installed in RHDH core here, but for 2.1 we are decoupling them and provide ability to install them dynamically.
Changes
Adds package metadata,
rhdh-supported-packages.txtentries, anddefault.packages.yaml(not OOTB enabled)catalog-backend-module-pingidentityas it was not meant to be GA, only the auth provider should be GACollateral changes